Skip to content

aws: downgrade credential provider info! log messages to debug! #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2025
+6 −6
Merged

aws: downgrade credential provider info! log messages to debug! #436

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/aws/builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ use serde::{Deserialize, Serialize};
use std::str::FromStr;
use std::sync::Arc;
use std::time::Duration;
use tracing::info;
use tracing::debug;
use url::Url;

/// Default metadata endpoint
Expand Down Expand Up @@ -943,7 +943,7 @@ impl AmazonS3Builder {
} else if self.access_key_id.is_some() || self.secret_access_key.is_some() {
match (self.access_key_id, self.secret_access_key, self.token) {
(Some(key_id), Some(secret_key), token) => {
info!("Using Static credential provider");
debug!("Using Static credential provider");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given these messages are just static strings, I agree that debug is a more appropriate level of logging in my opinion

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i agree with this.

let credential = AwsCredential {
key_id,
secret_key,
Expand All @@ -960,7 +960,7 @@ impl AmazonS3Builder {
std::env::var("AWS_ROLE_ARN"),
) {
// TODO: Replace with `AmazonS3Builder::credentials_from_env`
info!("Using WebIdentity credential provider");
debug!("Using WebIdentity credential provider");

let session_name = std::env::var("AWS_ROLE_SESSION_NAME")
.unwrap_or_else(|_| "WebIdentitySession".to_string());
Expand All @@ -983,7 +983,7 @@ impl AmazonS3Builder {
self.retry_config.clone(),
)) as _
} else if let Some(uri) = self.container_credentials_relative_uri {
info!("Using Task credential provider");
debug!("Using Task credential provider");

let options = self.client_options.clone().with_allow_http(true);

Expand All @@ -998,7 +998,7 @@ impl AmazonS3Builder {
self.container_credentials_full_uri,
self.container_authorization_token_file,
) {
info!("Using EKS Pod Identity credential provider");
debug!("Using EKS Pod Identity credential provider");

let options = self.client_options.clone().with_allow_http(true);

Expand All @@ -1010,7 +1010,7 @@ impl AmazonS3Builder {
cache: Default::default(),
}) as _
} else {
info!("Using Instance credential provider");
debug!("Using Instance credential provider");

let token = InstanceCredentialProvider {
imdsv1_fallback: self.imdsv1_fallback.get()?,
Expand Down