Implements Sum,sum_checked,min,max,is Distict,inverse for REE. #7933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncludes helper functions for expanding REE into logical represention
rich-t-kid-datadog
force-pushed
the
baah/AggregationSupport
branch
from
4ded72e to
05fb3c0
Compare
…tion is the only function left
rich-t-kid-datadog
force-pushed
the
baah/AggregationSupport
branch
from
05fb3c0 to
72bd81a
Compare
Rich-T-kid
reviewed
Jul 18, 2025
Rich-T-kid
reviewed
Jul 18, 2025
Rich-T-kid
reviewed
Jul 18, 2025
Rich-T-kid
reviewed
Jul 18, 2025
gabotechs
reviewed
Jul 22, 2025
…ly without expanding to logical form.
rich-t-kid-datadog
force-pushed
the
baah/AggregationSupport
branch
from
5688ad3 to
9d00687
Compare
rich-t-kid-datadog
changed the title
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This PR works towards closing the larger REE Epic
Rationale for this change
Add operations onto the REE datatype such as
What changes are included in this PR?
Allows for REE columns to be used for the previously mentioned functions correctly and efficently.
Are these changes tested?
Yes, comprehensive tests have been added in arrow-ord/src/cmp.rs and arrow-arith/src/aggregate.rs:
Are there any user-facing changes?
Performance improvement: REE distinct operations are now much faster for datasets with repeated values
No API changes: Existing distinct() and not_distinct() functions work the same way but are now more efficient for REE arrays
No breaking changes: All existing functionality is preserved
If there are user-facing changes then we may require documentation to be updated before approving the PR.
If there are any breaking changes to public APIs, please call them out.