[Variant] Minor: Add comments to tickets for follow on items #8092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
changed the title
alamb
changed the title
alamb
commented
Aug 7, 2025
| } | ||
| } | ||
|
|
||
| // todo for other primitive types |
There was a problem hiding this comment.
drive by cleanup (to quote @houqp from a long time ago)
|
Since this just adds some comments, I am going to merge this one in once CI passes |
alamb
commented
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
variant_getand ShreddedVariantArray#8021Rationale for this change
Let's add links to the relevant tickets in the code so future readers who encounter it can find the relevant context
What changes are included in this PR?
Add comments with links to tickets
Are these changes tested?
N/A (just comments)
Are there any user-facing changes?
No