Skip to content

[Variant] Support read-only metadata builders #8208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 25, 2025
Merged

[Variant] Support read-only metadata builders #8208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
80d47cc
[Variant] Support read-only metadata builders
scovich Aug 22, 2025
07a2dd3
add unit tests
scovich Aug 22, 2025
24ac0ad
self review
scovich Aug 22, 2025
1a4493b
clippy
scovich Aug 22, 2025
9680717
Merge remote-tracking branch 'oss/main' into metadata-builder-trait
scovich Aug 23, 2025
100d78f
logical conflict: need new trait method
scovich Aug 23, 2025
b66a625
review comments
scovich Aug 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions parquet-variant-compute/src/variant_array_builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ use crate::VariantArray;
use arrow::array::{ArrayRef, BinaryViewArray, BinaryViewBuilder, NullBufferBuilder, StructArray};
use arrow_schema::{ArrowError, DataType, Field, Fields};
use parquet_variant::{ListBuilder, ObjectBuilder, Variant, VariantBuilderExt};
use parquet_variant::{MetadataBuilder, ParentState, ValueBuilder};
use parquet_variant::{ParentState, ValueBuilder, WritableMetadataBuilder};
use std::sync::Arc;

/// A builder for [`VariantArray`]
Expand Down Expand Up @@ -74,7 +74,7 @@ pub struct VariantArrayBuilder {
/// Nulls
nulls: NullBufferBuilder,
/// builder for all the metadata
metadata_builder: MetadataBuilder,
metadata_builder: WritableMetadataBuilder,
/// ending offset for each serialized metadata dictionary in the buffer
metadata_offsets: Vec<usize>,
/// builder for values
Expand All @@ -96,7 +96,7 @@ impl VariantArrayBuilder {

Self {
nulls: NullBufferBuilder::new(row_capacity),
metadata_builder: MetadataBuilder::default(),
metadata_builder: WritableMetadataBuilder::default(),
metadata_offsets: Vec::with_capacity(row_capacity),
value_builder: ValueBuilder::new(),
value_offsets: Vec::with_capacity(row_capacity),
Expand Down
Loading
Loading