-
Notifications
You must be signed in to change notification settings - Fork 1k
[Variant] Implement row builders for cast_to_variant #8299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
55 commits
Select commit
Hold shift + click to select a range
61c3efb
Define VariantBuilderExt::append_null
scovich ea1147f
checkpoint - primitive builders
scovich bd565cf
manual fixup
scovich 358e2f8
checkpoint - change to enum instead of trait
scovich e6caaaf
manual fixup
scovich 470fffb
manual fixup
scovich f129824
checkpoint - run end
scovich 74d7da1
manual cleanup
scovich 9f361fd
simplify run end management
scovich 471a8ab
checkpoint - dictionary array
scovich 82ccc23
manual cleanup
scovich e08e07c
checkpoint - lists
scovich 87a3678
checkpoint - lists w/o slicing
scovich 2ac5f6d
manual cleanup
scovich 4d8da85
checkpoint - maps and null map fix
scovich 70a0c75
manual cleanup
scovich b9239bb
checkpoint - unions
scovich 5b5ede7
manual cleanup
scovich 18bfe04
checkpoint - float16
scovich b5eaaa4
checkpoint - decimal
scovich 24a1d44
manual fixup
scovich 9db05f1
checkpoint - binary and string
scovich abd9378
manual fixes
scovich 582dc7f
checkpoint - use offset size trait for string and binary buildres
scovich 1c3fcf3
checkpoint - timstamps
scovich dc2d2ae
manual fixes
scovich 493de5d
checkpoint - avoid deprecated timestamp functions
scovich 9de68eb
only need to track whether a timestamp has a time zone
scovich 805abad
checkpoint - date and time
scovich 29d445a
checkpoint - template date and time builders
scovich 7698de9
checkpoint - cast_to_variant uses row builders
scovich ca4ba9f
fix one unit test
scovich 658c263
delete dead code
scovich fe14de2
checkpoint - use macros to define row builders
scovich fa4ea64
Revert "checkpoint - use macros to define row builders"
scovich e89b642
make primitive and string builder templates more similar
scovich 53db9dc
checkpoint - start at simple builder macro
scovich 64d6877
manual fixes
scovich 1ad4cc3
expand macro to allow value transform
scovich eee43ce
checkpoint - use macro for time and date
scovich 6ffd231
checkpoint - macro support snon-generic row builders
scovich ad9ccf8
checkpoint - macro supports extra fields
scovich f5675de
manual fix - macro hygiene
scovich 4e9c697
checkpoint - better hygiene solution
scovich 637efde
manual fix - remove turbofish
scovich 20300c8
fmt
scovich a8c667d
diff minimization
scovich 583f7b8
split out a new module for the builders
scovich c3603d6
fmt
scovich 5607503
Merge remote-tracking branch 'oss/main' into cast-to-variant-row-builder
scovich 22a7745
self review
scovich c9fdb8c
simpler macro usage
scovich 26ae5c0
Merge remote-tracking branch 'oss/main' into cast-to-variant-row-builder
scovich 96256a3
cosmetic cleanups
scovich 6622e86
helper functions to reduce boiler plate in unit tests
scovich File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is ~800 LoC (much of that boilerplate), plus 1600 LoC of new unit tests (covering all supported types).