[Variant] Add constants for empty variant metadata #8359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scovich
commented
Sep 16, 2025
alamb
approved these changes
Sep 16, 2025
There was a problem hiding this comment.
Thanks @scovich -- makes sense to me
cc @codephage2020 and @klion26 and @mbrobbel
| /// let metadata_bytes = metadata_builder.into_inner(); | ||
| /// assert_eq!(&metadata_bytes, EMPTY_VARIANT_METADATA_BYTES); | ||
| /// ``` | ||
| pub const EMPTY_VARIANT_METADATA_BYTES: &[u8] = &[1, 0, 0]; |
|
This makes it more readable; thank you for the improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax.
Rationale for this change
Variant metadata only "matters" for variant values that contain objects. Especially in unit tests, it is common for a given variant value to have an empty variant metadata -- often one created separately and replicated across many rows.
What changes are included in this PR?
Define new constants,
EMPTY_VARIANT_METADATA_BYTESandEMPTY_VARIANT_METADATA, which are exactly what they sound like.Are these changes tested?
New doc tests, and several unit tests were updated to use it as well.
Are there any user-facing changes?
New constants