Skip to content

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Sep 18, 2025

Which issue does this PR close?

Rationale for this change

What changes are included in this PR?

Add more documentation to various parquet writing APIs

Are these changes tested?

By CI

Are there any user-facing changes?

Documentation only, no function changes

@github-actions github-actions bot added the parquet Changes to the parquet crate label Sep 18, 2025
@alamb alamb force-pushed the alamb/even_moar_parquet_docs branch from f4b55af to cfc1433 Compare September 18, 2025 17:52
@alamb alamb marked this pull request as ready for review September 18, 2025 17:53
@alamb
Copy link
Contributor Author

alamb commented Sep 18, 2025

As much as I would love to document this code some more, I think this is at least an improvement over the current status quo

@alamb alamb added the documentation Improvements or additions to documentation label Sep 18, 2025
Copy link
Contributor

@etseidl etseidl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alamb. As you say, it's an improvement 😄

@alamb alamb merged commit 06c638f into apache:main Sep 19, 2025
16 checks passed
@alamb
Copy link
Contributor Author

alamb commented Sep 19, 2025

Thanks for the review @etseidl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants