Skip to content

Fix red main by updating test #8421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2025
+18 −18
Merged

Fix red main by updating test #8421

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 18 additions & 18 deletions parquet/tests/variant_integration.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,18 +142,18 @@ variant_test_case!(38, "Unsupported typed_value type: Struct(");
variant_test_case!(39);
// Is an error case (should be failing as the expected error message indicates)
variant_test_case!(40, "Unsupported typed_value type: List(");
variant_test_case!(41, "Unsupported typed_value type: List(Field");
variant_test_case!(41, "Unsupported typed_value type: List(");
// Is an error case (should be failing as the expected error message indicates)
variant_test_case!(
42,
"Expected an error 'Invalid variant, conflicting value and typed_value`, but got no error"
);
// https://github.com/apache/arrow-rs/issues/8336
variant_test_case!(43, "Unsupported typed_value type: Struct([Field");
variant_test_case!(44, "Unsupported typed_value type: Struct([Field");
variant_test_case!(43, "Unsupported typed_value type: Struct(");
variant_test_case!(44, "Unsupported typed_value type: Struct(");
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This didn't fail… yet, but will need to be updated in #8291 anyways

// https://github.com/apache/arrow-rs/issues/8337
variant_test_case!(45, "Unsupported typed_value type: List(Field");
variant_test_case!(46, "Unsupported typed_value type: Struct([Field");
variant_test_case!(45, "Unsupported typed_value type: List(");
variant_test_case!(46, "Unsupported typed_value type: Struct(");
variant_test_case!(47);
variant_test_case!(48);
variant_test_case!(49);
Expand Down Expand Up @@ -191,14 +191,14 @@ variant_test_case!(80);
variant_test_case!(81);
variant_test_case!(82);
// https://github.com/apache/arrow-rs/issues/8336
variant_test_case!(83, "Unsupported typed_value type: Struct([Field");
variant_test_case!(84, "Unsupported typed_value type: Struct([Field");
variant_test_case!(83, "Unsupported typed_value type: Struct(");
variant_test_case!(84, "Unsupported typed_value type: Struct(");
// https://github.com/apache/arrow-rs/issues/8337
variant_test_case!(85, "Unsupported typed_value type: List(Field");
variant_test_case!(86, "Unsupported typed_value type: List(Field");
variant_test_case!(85, "Unsupported typed_value type: List(");
variant_test_case!(86, "Unsupported typed_value type: List(");
// Is an error case (should be failing as the expected error message indicates)
variant_test_case!(87, "Unsupported typed_value type: Struct([Field");
variant_test_case!(88, "Unsupported typed_value type: List(Field");
variant_test_case!(87, "Unsupported typed_value type: Struct(");
variant_test_case!(88, "Unsupported typed_value type: List(");
variant_test_case!(89);
variant_test_case!(90);
variant_test_case!(91);
Expand Down Expand Up @@ -243,17 +243,17 @@ variant_test_case!(
"Invalid variant data: InvalidArgumentError(\"Received empty bytes\")"
);
// Is an error case (should be failing as the expected error message indicates)
variant_test_case!(128, "Unsupported typed_value type: Struct([Field");
variant_test_case!(128, "Unsupported typed_value type: Struct(");
variant_test_case!(129, "Invalid variant data: InvalidArgumentError(");
variant_test_case!(130, "Unsupported typed_value type: Struct([Field");
variant_test_case!(130, "Unsupported typed_value type: Struct(");
variant_test_case!(131);
variant_test_case!(132, "Unsupported typed_value type: Struct([Field");
variant_test_case!(133, "Unsupported typed_value type: Struct([Field");
variant_test_case!(134, "Unsupported typed_value type: Struct([Field");
variant_test_case!(132, "Unsupported typed_value type: Struct(");
variant_test_case!(133, "Unsupported typed_value type: Struct(");
variant_test_case!(134, "Unsupported typed_value type: Struct(");
variant_test_case!(135);
variant_test_case!(136, "Unsupported typed_value type: List(Field ");
variant_test_case!(136, "Unsupported typed_value type: List(");
variant_test_case!(137, "Invalid variant data: InvalidArgumentError(");
variant_test_case!(138, "Unsupported typed_value type: Struct([Field");
variant_test_case!(138, "Unsupported typed_value type: Struct(");

/// Test case definition structure matching the format from
/// `parquet-testing/parquet_shredded/cases.json`
Expand Down
Loading