[Variant] Reverse VariantAsPrimitive trait to PrimitiveFromVariant #8519
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
The existing
VariantAsPrimitive
trait is kind of "backward" and requires very complex type bounds to use, e.g.:This is a code smell.
What changes are included in this PR?
"Reverse" the trait -- instead of extending
Variant
, the trait extendsT: ArrowPrimitiveType
. The resulting type bounds are much more intuitive:Are these changes tested?
Existing unit tests cover this refactor.
Are there any user-facing changes?
No.