Skip to content

[Parquet] Minor: Update comments in page decompressor #8764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 6, 2025
Merged

[Parquet] Minor: Update comments in page decompressor #8764

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ba0324
Update comments in page decompressor
alamb Nov 1, 2025
cae8d57
Update parquet/src/file/serialized_reader.rs
alamb Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions parquet/src/file/serialized_reader.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,8 +387,6 @@ pub(crate) fn decode_page(
can_decompress = header_v2.is_compressed.unwrap_or(true);
}

// TODO: page header could be huge because of statistics. We should set a
// maximum page header size and abort if that is exceeded.
let buffer = match decompressor {
Some(decompressor) if can_decompress => {
let uncompressed_page_size = usize::try_from(page_header.uncompressed_page_size)?;
Expand All @@ -398,6 +396,8 @@ pub(crate) fn decode_page(
let decompressed_size = uncompressed_page_size - offset;
let mut decompressed = Vec::with_capacity(uncompressed_page_size);
decompressed.extend_from_slice(&buffer[..offset]);
// decompressed size of zero corresponds to a page with no non-null values
// see https://github.com/apache/parquet-format/blob/master/README.md#data-pages
if decompressed_size > 0 {
let compressed = &buffer[offset..];
decompressor.decompress(compressed, &mut decompressed, Some(decompressed_size))?;
Expand Down
Loading