Add FilterBuilder::is_optimize_beneficial #8782
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52 tasks
alamb
approved these changes
Nov 9, 2025
| } | ||
|
|
||
| /// Compute an optimised representation of the provided `filter` mask that can be | ||
| /// Compute an optimized representation of the provided `filter` mask that can be |
Contributor
There was a problem hiding this comment.
100% for consistent (american) spelling
Contributor
|
Since I had some thoughts about comments, I'll just push them directly to the PR |
…w-rs into optimize_filter_beneficial
Contributor
|
CI was failing due to which was fixed in arrow-go I merged up to get a clean run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
FilterBuilder::optimizeor not #8781.Rationale for this change
See problem statement in #8781
What changes are included in this PR?
multiple_arrayshas been moved toFilterBuilderand made publicis_optimize_beneficialto make it intention revealing rather than a description of the implementationAre these changes tested?
No functional changes
Are there any user-facing changes?
No breaking changes