Skip to content

Conversation

@tustvold
Copy link
Contributor

These tests were all commented out in #9329. Given the PR made changes to the commented out code, I'm inclined to think this was an accidental omission? If not, happy for this to be closed 😀

FYI @jorgecarleitao

Signed-off-by: Raphael Taylor-Davies [email protected]

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tustvold

@tustvold tustvold changed the title ARROW-12400: Re-enable tests in arrow::array::transform ARROW-12400: [Rust] Re-enable tests in arrow::array::transform Apr 15, 2021
Copy link
Member

@jorgecarleitao jorgecarleitao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, @tustvold 👍

@github-actions
Copy link

@codecov-io
Copy link

Codecov Report

Merging #10048 (3d3f407) into master (26a5a04) will increase coverage by 0.24%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10048      +/-   ##
==========================================
+ Coverage   78.70%   78.95%   +0.24%     
==========================================
  Files         286      286              
  Lines       64213    64664     +451     
==========================================
+ Hits        50538    51054     +516     
+ Misses      13675    13610      -65     
Impacted Files Coverage Δ
rust/arrow/src/array/transform/mod.rs 93.20% <100.00%> (+22.96%) ⬆️
rust/parquet/src/encodings/encoding.rs 95.05% <0.00%> (+0.19%) ⬆️
rust/arrow/src/array/equal/mod.rs 93.58% <0.00%> (+0.34%) ⬆️
rust/arrow/src/array/data.rs 78.37% <0.00%> (+1.50%) ⬆️
rust/arrow/src/array/array_binary.rs 89.86% <0.00%> (+3.80%) ⬆️
rust/arrow/src/array/transform/variable_size.rs 100.00% <0.00%> (+12.12%) ⬆️
rust/arrow/src/array/transform/primitive.rs 100.00% <0.00%> (+28.57%) ⬆️
rust/arrow/src/array/transform/structure.rs 83.33% <0.00%> (+38.88%) ⬆️
rust/arrow/src/array/transform/null.rs 66.66% <0.00%> (+66.66%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c394a20...3d3f407. Read the comment docs.

@kszucs
Copy link
Member

kszucs commented Apr 15, 2021

@andygrove I assume we'd like to have it in the release.

@alamb
Copy link
Contributor

alamb commented Apr 15, 2021

@andygrove I assume we'd like to have it in the release.

FWIW @kszucs I don't think this is something that we should hold the release for -- it does not have any change to the actual code, only the tests.

@kszucs
Copy link
Member

kszucs commented Apr 15, 2021

Ok, thought that implementation was affected as well. I'm still waiting for other PRs so feel free to merge on green.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.95%. Comparing base (26a5a04) to head (3d3f407).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10048      +/-   ##
==========================================
+ Coverage   78.70%   78.95%   +0.24%     
==========================================
  Files         286      286              
  Lines       64213    64664     +451     
==========================================
+ Hits        50538    51054     +516     
+ Misses      13675    13610      -65     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants