-
Notifications
You must be signed in to change notification settings - Fork 3.9k
ARROW-12400: [Rust] Re-enable tests in arrow::array::transform #10048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Raphael Taylor-Davies <[email protected]>
alamb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @tustvold
jorgecarleitao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, @tustvold 👍
Codecov Report
@@ Coverage Diff @@
## master #10048 +/- ##
==========================================
+ Coverage 78.70% 78.95% +0.24%
==========================================
Files 286 286
Lines 64213 64664 +451
==========================================
+ Hits 50538 51054 +516
+ Misses 13675 13610 -65
Continue to review full report at Codecov.
|
|
@andygrove I assume we'd like to have it in the release. |
FWIW @kszucs I don't think this is something that we should hold the release for -- it does not have any change to the actual code, only the tests. |
|
Ok, thought that implementation was affected as well. I'm still waiting for other PRs so feel free to merge on green. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10048 +/- ##
==========================================
+ Coverage 78.70% 78.95% +0.24%
==========================================
Files 286 286
Lines 64213 64664 +451
==========================================
+ Hits 50538 51054 +516
+ Misses 13675 13610 -65 ☔ View full report in Codecov by Sentry. |
These tests were all commented out in #9329. Given the PR made changes to the commented out code, I'm inclined to think this was an accidental omission? If not, happy for this to be closed 😀
FYI @jorgecarleitao
Signed-off-by: Raphael Taylor-Davies [email protected]