Skip to content

Conversation

@pitrou
Copy link
Member

@pitrou pitrou commented Oct 30, 2025

Rationale for this change

The StatisticsAsScalars function, which allows converting Parquet statistics (min/max values) for a given logical type into Arrow scalars, did not support DECIMAL columns with physical type INT32 or INT64.

Are these changes tested?

Yes, by expanded unit test.

Are there any user-facing changes?

No, just a bug fix.

@github-actions
Copy link

⚠️ GitHub issue #47955 has been automatically assigned in GitHub to PR creator.

@pitrou pitrou marked this pull request as ready for review October 30, 2025 10:34
@pitrou pitrou requested a review from wgtmac as a code owner October 30, 2025 10:34
@pitrou pitrou requested a review from adamreeve October 30, 2025 10:35
Copy link
Contributor

@adamreeve adamreeve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me thanks @pitrou

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Oct 30, 2025
@pitrou pitrou merged commit 65f7787 into apache:main Oct 31, 2025
40 of 42 checks passed
@pitrou pitrou removed the awaiting committer review Awaiting committer review label Oct 31, 2025
@pitrou pitrou deleted the gh47955-decimal-int-stats branch October 31, 2025 08:12
@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 0 benchmarking runs that have been run so far on merge-commit 65f7787.

None of the specified runs were found on the Conbench server.

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants