-
Notifications
You must be signed in to change notification settings - Fork 3.9k
GH-47728: [Python] Check the source argument in parquet.read_table #48008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rmnskb
wants to merge
6
commits into
apache:main
Choose a base branch
from
rmnskb:gh-47728-check-source-pq-read
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+27
−3
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
3a75c25
Check that source is not a directory or a list in read_table
rmnskb c420c0f
Add test for read_table if pyarrow.dataset is unavailable
rmnskb d301489
Fix linter issue
rmnskb 4f219f3
Specify the match for pytest.raises
rmnskb cea6bb7
Check if the source is a file directly
rmnskb c7c44f9
Update test_read_table_without_dataset test
rmnskb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -16,6 +16,7 @@ | |||||||
| # under the License. | ||||||||
|
|
||||||||
| import os | ||||||||
| import sys | ||||||||
| from collections import OrderedDict | ||||||||
| import io | ||||||||
| import warnings | ||||||||
|
|
@@ -185,8 +186,7 @@ def __init__(self, *args, **kwargs): | |||||||
| pq.read_table(path, partitioning=['week', 'color']) | ||||||||
| with pytest.raises(ValueError, match="the 'schema' argument"): | ||||||||
| pq.read_table(path, schema=table.schema) | ||||||||
| # Error message varies depending on OS | ||||||||
| with pytest.raises(OSError): | ||||||||
| with pytest.raises(ValueError, match="the 'source' argument"): | ||||||||
| pq.read_table(tempdir) | ||||||||
| result = pq.read_table(path) | ||||||||
| assert result == table | ||||||||
|
|
@@ -993,3 +993,14 @@ def test_checksum_write_to_dataset(tempdir): | |||||||
| # checksum verification enabled raises an exception | ||||||||
| with pytest.raises(OSError, match="CRC checksum verification"): | ||||||||
| _ = pq.read_table(corrupted_file_path, page_checksum_verification=True) | ||||||||
|
|
||||||||
|
|
||||||||
| @pytest.mark.parametrize( | ||||||||
| "source", ["/tmp/", ["/tmp/file1.parquet", "/tmp/file2.parquet"]]) | ||||||||
| def test_read_table_raises_value_error_when_ds_is_unavailable( | ||||||||
| monkeypatch, source): | ||||||||
|
Comment on lines
+1000
to
+1001
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
| # GH-47728 | ||||||||
| monkeypatch.setitem(sys.modules, "pyarrow.dataset", None) | ||||||||
|
|
||||||||
| with pytest.raises(ValueError, match="the 'source' argument"): | ||||||||
| pq.read_table(source=source) | ||||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.