Use the newest git and prefetch OWASP database

[jacek-lewandowski]

No description provided.

[michaelsembwever]

what version of git do you need?
what version is ubuntu:20.04 providing?

we want a clear comment about this being temporary and when it can be removed.

[jacek-lewandowski]

ubuntu provides 2.25.1
we need at least 2.30.0
the command currently installs 2.41.0

tbh I don't know why wouldn't we ever use the newest one

[michaelsembwever]

It's still unclear to me where you are using this, and why you are not using the .build/docker/check-code.sh script instead?

[jacek-lewandowski]

@michaelsembwever - this is for CircleCI, we always get new workers from the cloud provider

[michaelsembwever]

repeating for prosperity…

So

1. cirecleci is going to be around long enough to warrant this
2. we need a image change just bc of git, adding db cache is additional value
3. it makes the dependency-check more robust (failures are often in the downloading?)
4. how much will it slow down a circleci run overall ? (adding x MB to the image, which is downloaded 1000+ times in one run)
5. will a newer image break any other jobs in circleci or ci-cassandra.a.o ?

so a custom image needs to be deployed to a personal dockerhub account first, and pre-commit tested on both circleci and ci-cassandra.a.o

i'm presuming (4) won't be a big issue, bc of caching.

[jacek-lewandowski]

Renamed branch - #94