MaxRequestsPerConn cluster param was added #1747
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@martin-sucha Hello, will be glad to receive your review on this PR! |
taaraora
reviewed
May 23, 2024
conn.go
Outdated
| compressor: cfg.Compressor, | ||
| session: s, | ||
| streams: streams.New(cfg.ProtoVersion), | ||
| streams: s.streamIDGenerator(cfg.ProtoVersion), |
There was a problem hiding this comment.
what if we call it newStreamIDGenerator?
Also is it obligatory to pass config there if we access cfg from attached type?
There was a problem hiding this comment.
Fixed, renamed and moved the function to the streams package.
taaraora
reviewed
May 23, 2024
| defer h.mu.Unlock() | ||
| addr, _ := h.connectAddressLocked() | ||
| return net.JoinHostPort(addr.String(), strconv.Itoa(h.port)) | ||
| h.mu.Lock() |
There was a problem hiding this comment.
I don't think it makes sense to format files which were not touched by the fix.
There was a problem hiding this comment.
Reverted these changes, but it seems that they stayed inside this PR :\
testisnullus
force-pushed
the
maxRequestsPerConn-cluster-param
branch
3 times, most recently
from
ba0fac8 to
88405bb
Compare
testisnullus
force-pushed
the
maxRequestsPerConn-cluster-param
branch
from
88405bb to
00ad04d
Compare
testisnullus
force-pushed
the
maxRequestsPerConn-cluster-param
branch
from
00ad04d to
65fc5c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pull request #1747 for the Cassandra gocql driver adds a new cluster parameter
MaxRequestsPerConn. This parameter allows users to configure the maximum number of requests per connection, enhancing the driver's configurability. Functionality was adopted from similar PR from the ScyllaDB project: scylladb#113Closes #1679