Skip to content

Fix initdb TAP tests. #1503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
reshke wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Fix initdb TAP tests. #1503

reshke wants to merge 6 commits into from
+1 −1

Conversation

@reshke
Copy link
Contributor

@reshke reshke commented Dec 23, 2025

Currently initdb TAP tests fails due to
number-of-checks assertions. Trivially fix specifying correct number of tests

@reshke
Fix initdb TAP tests.
5aab0f0 
Currently initdb TAP tests fails due to
number-of-checks assertions. Trivially fix specifying correct number
of tests
@reshke reshke added the TAP label Dec 23, 2025
@reshke
Copy link
Contributor Author

reshke commented Dec 23, 2025 •
edited
Loading

As I can see in #1506
TAP tests run in CI also expects 24 tests

# Looks like you planned 22 tests but ran 24.
t/001_initdb.pl .. 
Dubious, test returned 255 (wstat 65280, 0xff00)
All 22 subtests passed 

Test Summary Report
-------------------
t/001_initdb.pl (Wstat: 65280 Tests: 24 Failed: 2)
  Failed tests:  23-24
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 22 tests but ran 24.
Files=1, Tests=24,  3 wallclock secs ( 0.02 usr  0.00 sys +  1.21 cusr  1.24 csys =  2.47 CPU)
Result: FAIL
make[1]: *** [Makefile:69: installcheck] Error 1
make[1]: Leaving directory '/__w/cloudberry/cloudberry/s

@reshke
Copy link
Contributor Author

reshke commented Dec 24, 2025

This is required for #1506 to work

@reshke reshke requested review from my-ship-it and tuhaihe December 24, 2025 11:18
my-ship-it
my-ship-it approved these changes Dec 30, 2025
View reviewed changes
Copy link
Contributor

@my-ship-it my-ship-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it. Just curious if the Tap test ran in CI already?

@reshke
Copy link
Contributor Author

reshke commented Dec 30, 2025

Thanks for fixing it. Just curious if the Tap test ran in CI already?

no, to enable this in CI we need something like #1506 , and this PR is a pre-requisite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@x4m x4m x4m approved these changes

@my-ship-it my-ship-it my-ship-it approved these changes

@tuhaihe tuhaihe Awaiting requested review from tuhaihe

Assignees

No one assigned

Labels

TAP

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@reshke @x4m @my-ship-it