Skip to content

Conversation

@reshke
Copy link
Contributor

@reshke reshke commented Dec 26, 2025

Fixes #ISSUE_Number

What does this PR do?

Type of Change

  • Bug fix (non-breaking change)
  • New feature (non-breaking change)
  • Breaking change (fix or feature with breaking changes)
  • Documentation update

Breaking Changes

Test Plan

  • Unit tests added/updated
  • Integration tests added/updated
  • Passed make installcheck
  • Passed make -C src/test installcheck-cbdb-parallel

Impact

Performance:

User-facing changes:

Dependencies:

Checklist

Additional Context

CI Skip Instructions


Copy link
Contributor

@leborchuk leborchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, new test fails with

make: *** No rule to make target 'create-demo-cluster'.  Stop.
Error: Process completed with exit code 2.

@tuhaihe
Copy link
Member

tuhaihe commented Dec 30, 2025

Sorry, new test fails with

make: *** No rule to make target 'create-demo-cluster'.  Stop.
Error: Process completed with exit code 2.

Now the test can run well, but has a new problem:

=== Running Tests for ic-small-opt-off ===
Make configurations: [
  "src/test/regress:installcheck-small"
]
-bash: line 13: jq: command not found

All tests completed successfully

Let me try to fix it later.

@tuhaihe
Copy link
Member

tuhaihe commented Dec 30, 2025

Now the workflow can run well, but the test failed. Please take a look at the file I've attached.

regression.diffs.txt

We can merge this PR and fix the test errors later, or fix them in this PR? What do you think? @reshke

@tuhaihe
Copy link
Member

tuhaihe commented Dec 30, 2025

Updates:

  • Now the CI workflow supports checking and displaying the regression diffs, without downloading the files.

Copy link
Contributor

@leborchuk leborchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, see the working test. Fixing is a long process. Let's start by showing the problems.

@tuhaihe tuhaihe merged commit e02c5a2 into cbdb-postgres-merge Dec 30, 2025
3 of 4 checks passed
@tuhaihe tuhaihe deleted the reshke-patch-try-smallinstallcheck branch December 30, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants