Skip to content

Conversation

weizhouapache
Copy link
Member

@weizhouapache weizhouapache commented Jul 3, 2025

Description

This PR replaces md5sum with sha512sum

requires #11469 to be merged.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Copy link

codecov bot commented Jul 3, 2025

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 17.36%. Comparing base (ca0c353) to head (1b63245).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...ain/java/com/cloud/storage/StorageManagerImpl.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #11134      +/-   ##
============================================
- Coverage     17.36%   17.36%   -0.01%     
+ Complexity    15237    15236       -1     
============================================
  Files          5888     5888              
  Lines        525737   525736       -1     
  Branches      64164    64164              
============================================
- Hits          91275    91272       -3     
- Misses       424163   424164       +1     
- Partials      10299    10300       +1     
Flag Coverage Δ
uitests 3.63% <ø> (ø)
unittests 18.40% <83.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@sureshanaparti
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14037

@weizhouapache
Copy link
Member Author

@blueorangutan test

@blueorangutan
Copy link

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@blueorangutan
Copy link

[SF] Trillian test result (tid-13688)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 54770 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11134-t13688-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@weizhouapache weizhouapache marked this pull request as ready for review July 7, 2025 11:37
Copy link

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@sureshanaparti
Copy link
Contributor

this needs upgrade tests

@weizhouapache
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14787

@weizhouapache
Copy link
Member Author

@blueorangutan test

@blueorangutan
Copy link

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-14153)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 54000 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11134-t14153-kvm-ol8.zip
Smoke tests completed. 143 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
ContextSuite context=TestClusterDRS>:setup Error 0.00 test_cluster_drs.py
test_list_system_vms_metrics_history Failure 0.24 test_metrics_api.py
test_04_rvpc_network_garbage_collector_nics Failure 1449.67 test_vpc_redundant.py

@weizhouapache
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14799

@weizhouapache
Copy link
Member Author

@blueorangutan test matrix

@blueorangutan
Copy link

@weizhouapache a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-14160)

@blueorangutan
Copy link

[SF] Trillian test result (tid-14159)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 53003 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11134-t14159-kvm-ol8.zip
Smoke tests completed. 144 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_08_arping_in_ssvm Failure 5.21 test_diagnostics.py
test_04_rvpc_network_garbage_collector_nics Failure 1449.25 test_vpc_redundant.py

@blueorangutan
Copy link

[SF] Trillian test result (tid-14163)
Environment: kvm-ubuntu22 (x2), zone: Advanced Networking with Mgmt server u22
Total time taken: 61011 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11134-t14163-kvm-ubuntu22.zip
Smoke tests completed. 145 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_04_rvpc_network_garbage_collector_nics Failure 1475.23 test_vpc_redundant.py

@blueorangutan
Copy link

[SF] Trillian test result (tid-14161)
Environment: vmware-70u3 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 74524 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11134-t14161-vmware-70u3.zip
Smoke tests completed. 143 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_list_vms_metrics_admin Error 3632.00 test_metrics_api.py
test_list_vms_metrics_history Error 7.92 test_metrics_api.py
test_list_volumes_metrics_history Error 3630.20 test_metrics_api.py
test_01_vpn_usage Error 1.11 test_usage.py
test_04_rvpc_network_garbage_collector_nics Failure 1492.75 test_vpc_redundant.py

@blueorangutan
Copy link

[SF] Trillian test result (tid-14162)
Environment: xcpng82 (x2), zone: Advanced Networking with Mgmt server ol9
Total time taken: 77218 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11134-t14162-xcpng82.zip
Smoke tests completed. 140 look OK, 6 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_non_strict_host_anti_affinity Error 185.61 test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity Error 77.80 test_nonstrict_affinity_group.py
test_01_primary_storage_iscsi Error 0.72 test_primary_storage.py
test_01_vpn_usage Error 1.10 test_usage.py
test_11_destroy_vm_and_volumes Error 23.16 test_vm_life_cycle.py
test_01_migrate_vm_strict_tags_success Error 60.09 test_vm_strict_host_tags.py
test_04_rvpc_network_garbage_collector_nics Failure 1635.81 test_vpc_redundant.py

@weizhouapache
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 14814

@weizhouapache
Copy link
Member Author

@blueorangutan test matrix

@blueorangutan
Copy link

@weizhouapache a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-14178)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 51294 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11134-t14178-kvm-ol8.zip
Smoke tests completed. 146 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@blueorangutan
Copy link

[SF] Trillian test result (tid-14179)
Environment: kvm-ubuntu22 (x2), zone: Advanced Networking with Mgmt server u22
Total time taken: 54230 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11134-t14179-kvm-ubuntu22.zip
Smoke tests completed. 145 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_create_pvlan_network Error 0.12 test_pvlan.py

@blueorangutan
Copy link

[SF] Trillian test result (tid-14180)
Environment: vmware-70u3 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 60972 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11134-t14180-vmware-70u3.zip
Smoke tests completed. 143 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
ContextSuite context=TestKubernetesCluster>:setup Error 0.00 test_kubernetes_clusters.py
test_01_primary_storage_nfs Error 0.19 test_primary_storage.py
ContextSuite context=TestStorageTags>:setup Error 0.33 test_primary_storage.py
test_01_primary_storage_scope_change Error 0.13 test_primary_storage_scope.py

@blueorangutan
Copy link

[SF] Trillian test result (tid-14181)
Environment: xcpng82 (x2), zone: Advanced Networking with Mgmt server ol9
Total time taken: 80173 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11134-t14181-xcpng82.zip
Smoke tests completed. 139 look OK, 7 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_events_resource Error 224.08 test_events_resource.py
test_01_non_strict_host_anti_affinity Error 210.77 test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity Error 52.37 test_nonstrict_affinity_group.py
test_01_primary_storage_iscsi Error 0.86 test_primary_storage.py
test_01_vpn_usage Error 1.10 test_usage.py
test_11_destroy_vm_and_volumes Error 22.01 test_vm_life_cycle.py
test_change_service_offering_for_vm_with_snapshots Failure 1004.91 test_vm_snapshots.py
test_01_migrate_vm_strict_tags_success Error 52.03 test_vm_strict_host_tags.py

@weizhouapache
Copy link
Member Author

Merging based on approvals and test results

I will investigate the smoke test failures on xcpng82

@weizhouapache weizhouapache merged commit 66a5846 into apache:main Sep 3, 2025
26 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Apache CloudStack 4.22.0 Sep 3, 2025
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Sep 4, 2025
* Update md5sum to sha512sum

* Move SQL to schema-42100to42200.sql
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants