-
Notifications
You must be signed in to change notification settings - Fork 1.2k
UI: Prevent restriction of changeOfferingForVolume API to Admin role #11466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.19 #11466 +/- ##
=========================================
Coverage 15.18% 15.18%
- Complexity 11369 11374 +5
=========================================
Files 5415 5415
Lines 476066 476066
Branches 58123 58123
=========================================
+ Hits 72281 72298 +17
+ Misses 395698 395678 -20
- Partials 8087 8090 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
UI build: ✔️ |
tested in qa |
Description
This PR fixes: #11437
Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?