Skip to content

Conversation

Pearl1594
Copy link
Contributor

Description

This PR fixes: #11437

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

  1. Created custom user role with change serviceoffering role permission allow (which is by default allowed even in user role (though not visible))
  2. the option is visible in the UI for a volume in Ready or Allocated state
  3. Changed the role permission to deny
  4. No longer see the option to change volume offering from UI for the user

How did you try to break this feature and the system with this change?

Copy link

codecov bot commented Aug 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 15.18%. Comparing base (25f93b1) to head (c9aeba3).
⚠️ Report is 1 commits behind head on 4.19.

Additional details and impacted files
@@            Coverage Diff            @@
##               4.19   #11466   +/-   ##
=========================================
  Coverage     15.18%   15.18%           
- Complexity    11369    11374    +5     
=========================================
  Files          5415     5415           
  Lines        476066   476066           
  Branches      58123    58123           
=========================================
+ Hits          72281    72298   +17     
+ Misses       395698   395678   -20     
- Partials       8087     8090    +3     
Flag Coverage Δ
uitests 4.28% <ø> (ø)
unittests 15.91% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland DaanHoogland added this to the 4.19.4 milestone Aug 20, 2025
@DaanHoogland DaanHoogland linked an issue Aug 20, 2025 that may be closed by this pull request
Copy link
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland
Copy link
Contributor

@blueorangutan ui

@blueorangutan
Copy link

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11466 (QA-JID-732)

@DaanHoogland
Copy link
Contributor

tested in qa

@DaanHoogland DaanHoogland merged commit f80a9ca into 4.19 Aug 29, 2025
48 of 49 checks passed
@DaanHoogland DaanHoogland deleted the allow-offering-change-vol-nonAdmin branch August 29, 2025 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change offeringForVolume access not reflected in UI
4 participants