Added Extension for MaaS integration in CloudStack #11613
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11613 +/- ##
============================================
+ Coverage 17.36% 17.39% +0.03%
- Complexity 15245 15285 +40
============================================
Files 5888 5888
Lines 525831 526130 +299
Branches 64183 64232 +49
============================================
+ Hits 91298 91542 +244
- Misses 424227 424255 +28
- Partials 10306 10333 +27
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@blueorangutan package |
harikrishna-patnala
changed the title
|
@harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 14951 |
harikrishna-patnala
force-pushed
the
ExtensionMaaS
branch
from
e551ba1 to
3498519
Compare
|
@blueorangutan package |
|
@harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15000 |
|
@harikrishna-patnala shouldn’t this be externalised and added on request at configuration/runtime instead of in the main repo? I know we did some initial integration within the repo, I just wonder if we should continue like that? cc @rohityadavcloud |
| @@ -0,0 +1,213 @@ | |||
| #!/usr/bin/env python3 | |||
| # Licensed to the Apache Software Foundation (ASF) under one | |||
There was a problem hiding this comment.
We need to add +x permissions to the file like hyperv.py and proxmox.sh. I don't recall the exact reason, but it was needed for some packaging.
There was a problem hiding this comment.
Added, thank you
| if state == "on": | ||
| mapped = "PowerOn" | ||
| elif state == "off": | ||
| mapped = "PowerOff" | ||
| else: | ||
| mapped = "PowerUnknown" |
There was a problem hiding this comment.
Not sure if it matters that much, but other extensions are using poweron, poweroff and unknown.
There was a problem hiding this comment.
We are comparing by ignoring case @Abhisar, so this should be fine. Any thing other than PowerOn and PowerOff is considered as PowerUnknown state, so unknown or powerunknown anything works.
Yeah we need not to continue adding like this @DaanHoogland but this will stand as a good example for baremetal provisionings. |
Description
This PR adds a new extension and script to support MaaS (https://canonical.com/maas) in CloudStack.
Doc PR : apache/cloudstack-documentation#561
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?