Skip to content

fix: new MediaFile() - fix wrong property name for localURL #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: new MediaFile() - fix wrong property name for localURL #54

wants to merge 2 commits into from

Conversation

tanasebutcaru
Copy link
Contributor

If manually created a MediaFile object and calling getFormatData on it, it will run into an error with code 2 (invalid argument).

MediaFile extends the File constructor, which does not have a filePath property.

@janpio janpio added the bug label Sep 17, 2018
@janpio janpio changed the title new MediaFile() - fix wrong property name for localURL fix: new MediaFile() - fix wrong property name for localURL Jul 4, 2019
janpio
janpio requested changes Jul 4, 2019
View reviewed changes
Copy link
Member

@janpio janpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard merge conflict, unsurprisingly after so much time.
Has to be checked if has already be fixed in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janpio janpio janpio requested changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tanasebutcaru @janpio