Add support for procedure parameter default values #2041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aharpervc
force-pushed
the
mssql-param-default-value
branch
2 times, most recently
from
f7f6284 to
6e18938
Compare
iffyio
reviewed
Sep 26, 2025
| } | ||
|
|
||
| #[test] | ||
| fn create_procedure_with_parameter_default_value() { |
There was a problem hiding this comment.
Can we merge the test into the existing parse_create_procedure_with_parameter_modes? since they cover the same feature
There was a problem hiding this comment.
Hm, I don't understand. A parameter can be in/out and still have/not have a default, right? Are you suggesting like
pub enum ArgMode {
In,
Out,
InOut,
+ InWithDefault(Expr),
+ OutWithDefault(Expr),
+ InOutWithDefault(Expr),
}Perhaps I'm not understanding
tests/sqlparser_common.rs
Outdated
|
|
||
| #[test] | ||
| fn create_procedure_with_parameter_default_value() { | ||
| let sql = r#"CREATE PROCEDURE test_proc (a INT = 42) AS BEGIN SELECT 1; END"#; |
There was a problem hiding this comment.
Can we add scenarios demonstrating
- multiple paramenters having defaults (i.e.
(a INT= 42, b INT=43)) - parameters that include a
mode
There was a problem hiding this comment.
Done 👍. I've also added an additional unit test for SQL Server, since the parameter identifier syntax is different there.
aharpervc
force-pushed
the
mssql-param-default-value
branch
from
6e18938 to
d05b63c
Compare
aharpervc
force-pushed
the
mssql-param-default-value
branch
from
d05b63c to
88da3b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, this now parses appropriately:
Syntax documentation reference: https://learn.microsoft.com/en-us/sql/t-sql/statements/create-procedure-transact-sql?view=sql-server-ver17#e-use-a-procedure-with-wildcard-parameters. This is the syntax used by SQL Server, but I've implemented this as a "normal" Option property of the ProcedureParam struct.
I also added a corresponding common unit test