Add reproducing test cases for stackoverflows #16787
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmed-mez
changed the title
|
cc @gabotechs and @LiaCastaneda |
gabotechs
approved these changes
Jul 16, 2025
| const DEPTH: usize = 3000; | ||
|
|
||
| #[tokio::test] | ||
| #[ignore] |
There was a problem hiding this comment.
Maybe add a comment about why is it ignored?
gabotechs
reviewed
Jul 16, 2025
There was a problem hiding this comment.
Do you think there could be a way of replicating this with the SQL path? something like dynamically building a deeply nested SQL statement that produces the same outcome?
There might be some value in showing the community that this is issue is not exclusive to Substrait, it might help gain some traction.
|
I'm just wondering should it be Gist instead? 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
This is a reproducer for #16788. See the issue for more context.
What changes are included in this PR?
An ignored test case that reproduces stack-overflows
Are these changes tested?
N/A
Are there any user-facing changes?
No