Add example of custom file schema casting rules #16803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriangb
commented
Jul 17, 2025
| @@ -433,7 +433,7 @@ impl ListingTableConfig { | |||
| /// `SchemaAdapterFactory` is set, in which case only the `SchemaAdapterFactory` will be used. | |||
| /// | |||
| /// See <https://github.com/apache/datafusion/issues/16800> for details on this transition. | |||
| pub fn with_physical_expr_adapter_factory( | |||
| pub fn with_expr_adapter_factory( | |||
There was a problem hiding this comment.
In writing the example I noticed that this name is very long and probably too verbose.
This tones it down and brings it in line with the field name.
There was a problem hiding this comment.
I love this explanation -- I have found trying to write out examples of using APIs almost always leads to discoveries of ways to improve them for the better. Thank you!
adriangb
commented
Jul 17, 2025
comphead
reviewed
Jul 17, 2025
| @@ -101,7 +101,7 @@ pub struct ListingTableConfig { | |||
| /// Optional [`SchemaAdapterFactory`] for creating schema adapters | |||
| schema_adapter_factory: Option<Arc<dyn SchemaAdapterFactory>>, | |||
| /// Optional [`PhysicalExprAdapterFactory`] for creating physical expression adapters | |||
| physical_expr_adapter_factory: Option<Arc<dyn PhysicalExprAdapterFactory>>, | |||
| expr_adapter_factory: Option<Arc<dyn PhysicalExprAdapterFactory>>, | |||
There was a problem hiding this comment.
this rename might cause api_change label along with Upgrade Guide changes, I would stick to just example in this PR?
There was a problem hiding this comment.
This API was added yesterday in #16791
comphead
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#16800 (comment)