Implement timestamp_cast_dtype for SqliteDialect #17479
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
PR improves unparser to produce valid CAST SQL for SQLite and
timestamp_text
Rationale for this change
SQLite does not have dedicated DATE type and prefers a text string that is an ISO 8601 date/time value.
Default implementation of
timestamp_cast_dtype
casts values toTimestamp
. However you can see below that casting toTIMESTAMP
produces invalid value in cast of sqlite, where casting toTEXT
produces a valid one:What changes are included in this PR?
PR introduces custom
timestamp_cast_dtype
implementation forSqliteDialect
.Are these changes tested?
Yes, added unit tests + manual testing
Are there any user-facing changes?
No