Skip to content

move MinAggregator and MaxAggregator to functions-aggregate-common #17492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2025
Merged

move MinAggregator and MaxAggregator to functions-aggregate-common #17492

merged 1 commit into from
Sep 10, 2025
+455 −449

Conversation

adriangb
Copy link
Contributor

@adriangb adriangb commented Sep 9, 2025 •
edited
Loading

@adriangb adriangb requested a review from alamb September 9, 2025 15:31
@github-actions github-actions bot added functions Changes to functions implementation datasource Changes to the datasource crate labels Sep 9, 2025
@adriangb adriangb mentioned this pull request Sep 9, 2025
Merged
@adriangb adriangb requested a review from comphead September 9, 2025 18:33
alamb
alamb approved these changes Sep 10, 2025
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @adriangb

Since this PR just moves code, I'll merge it quickly to avoid conflicts and avoid building a queue

datafusion/datasource-parquet/Cargo.toml
@@ -40,7 +40,7 @@ datafusion-common-runtime = { workspace = true }
datafusion-datasource = { workspace = true, features = ["parquet"] }
datafusion-execution = { workspace = true }
datafusion-expr = { workspace = true }
datafusion-functions-aggregate = { workspace = true }
datafusion-functions-aggregate-common = { workspace = true }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great

@alamb alamb merged commit ab108a5 into apache:main Sep 10, 2025
31 checks passed
@adriangb
Copy link
Contributor Author

Followup: #17502

@adriangb adriangb deleted the move-aggregators branch September 10, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

@comphead comphead Awaiting requested review from comphead

Assignees
No one assigned
Labels
datasource Changes to the datasource crate functions Changes to functions implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adriangb @alamb