Skip to content

Conversation

@foskey51
Copy link
Contributor

Which issue does this PR close?

What changes are included in this PR?

I've enabled the navbar, which is required to use dark-light mode toggle and made following changes in the ui

  • Removed the existing logo in the side-bar (as it was redundant)
  • Removed search bar in the side-bar (as it was conflicting with navbar's search widget)

image

image

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 28, 2025
@Jefffrey
Copy link
Contributor

Some things I noticed:

  • Toggle has 3 states (and 3 different icons)
  • Theme is remembered per page, not globally; e.g. if I set light mode (default is dark) on home/index page, and I navigate to another page, that page will be dark but when I navigate back to home it'll be light
  • The More menu on the navbar doesn't play well given it's length, might be better off removing it
  • I also prefer removing the other links on the navbar (e.g. License, Donate) given they are also at the top of the sidebar; either keep the sidebar ones or keep only the navbar ones to remove this duplication

@foskey51
Copy link
Contributor Author

hey @Jefffrey

  • Your are seeing 3 states (light, dark, system-theme) because it's default and there's no implicit way to remove the system-theme aka third state you can refer this issue, explicitly removing it might cause unexpected behavior.

  • The "theme is remembered per page" is caused due to accessing the index.html directly as file:///xyz/datafusion/docs/build/html/index.html so now dev-tools>storage>local-storage variables responsible for theming are tracked by dynamically changing file name which ends-up getting a new default state for each file. To resolve this, try serving it via a http server like

#run it in docs/ dir
python3 -m http.server 8000

#access the docs build at
http://localhost:8000/build/html/index.html

now local storage tracks it by host-name aka http://localhost:8000. So this shouldn't be an issue in production, as it will be tracked by domain name.

  • I've removed the links displayed in the navbar.


Screenshot 2025-10-29 at 21-12-33 Apache DataFusion — Apache DataFusion documentation(2)

Copy link
Contributor

@Jefffrey Jefffrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the detailed reply, you're right with running it via HTTP server fixes the issue with modes across pages. And I checked Arrow page and it also has the three toggle modes: https://arrow.apache.org/docs/format/Columnar.html

I think this is good to go in that case

@foskey51
Copy link
Contributor Author

Sounds good 👍

@alamb
Copy link
Contributor

alamb commented Oct 30, 2025

I also tried it out locally and it worked great

Thank you @foskey51

Screenshot 2025-10-30 at 2 48 05 PM

@Jefffrey Jefffrey added this pull request to the merge queue Oct 31, 2025
Merged via the queue into apache:main with commit 41566db Oct 31, 2025
5 checks passed
@Jefffrey
Copy link
Contributor

Thanks @foskey51

@foskey51 foskey51 deleted the feat/enable-navbar branch October 31, 2025 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Website: dark mode toggle

3 participants