-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(docs): enable navbar #18324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docs): enable navbar #18324
Conversation
|
Some things I noticed:
|
|
hey @Jefffrey
now local storage tracks it by host-name aka
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the detailed reply, you're right with running it via HTTP server fixes the issue with modes across pages. And I checked Arrow page and it also has the three toggle modes: https://arrow.apache.org/docs/format/Columnar.html
I think this is good to go in that case
|
Sounds good 👍 |
|
I also tried it out locally and it worked great Thank you @foskey51
|
|
Thanks @foskey51 |


Which issue does this PR close?
What changes are included in this PR?
I've enabled the navbar, which is required to use dark-light mode toggle and made following changes in the ui