Change default time_zone to None (was "+00:00")
#18359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s a side effect.
github-actions
bot
added
documentation
alamb
changed the title
time_zone to None (was "+00:00")
alamb
approved these changes
Oct 29, 2025
Weijun-H
approved these changes
Oct 30, 2025
| | datafusion.execution.collect_statistics | true | Should DataFusion collect statistics when first creating a table. Has no effect after the table is created. Applies to the default `ListingTableProvider` in DataFusion. Defaults to true. | | ||
| | datafusion.execution.target_partitions | 0 | Number of partitions for query execution. Increasing partitions can increase concurrency. Defaults to the number of CPU cores on the system | | ||
| | datafusion.execution.time_zone | +00:00 | The default time zone Some functions, e.g. `EXTRACT(HOUR from SOME_TIME)`, shift the underlying datetime according to this time zone, and then extract the hour | | ||
| | datafusion.execution.time_zone | NULL | The default time zone Some functions, e.g. `now` return timestamps in this time zone | |
There was a problem hiding this comment.
Suggested change
| | datafusion.execution.time_zone | NULL | The default time zone Some functions, e.g. `now` return timestamps in this time zone | | |
| | datafusion.execution.time_zone | NULL | The default time zone. Some functions, e.g. `now` return timestamps in this time zone. If set to NULL, no time zone is applied. | |
There was a problem hiding this comment.
Currently that isn't supported:
1. statement failed: DataFusion error: Error during planning: Unsupported value Null
[SQL] SET TIMEZONE = NULL
at /opt/dev/datafusion/datafusion/sqllogictest/test_files/set_variable.slt:176
An empty string works though the returned value is (empty) not null.
I'll take a look at what it'll take to support null.
There was a problem hiding this comment.
@Weijun-H Supporting un-setting a config option will be more than just a small change and I think that should be done in a separate PR. Right now it will cause a plan_err to be returned.
Currently the SetVariable struct requires a string, changing that to an option will require threading that change throughout the codebase + additional testing.
|
I merged up to resolve a conflict |
|
I'll merge up to fix the conflict tonight or tomorrow. |
…e_zone # Conflicts: # datafusion/functions/src/datetime/now.rs
|
Thank you @Omega359 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
ExecutionOptions::time_zonetoOption#18081Rationale for this change
Default timezone was previously zulu however with the recent change to support default tz in now(), current_date(), etc which used to have no default tz the choice was made to unset the system wide timezone.
What changes are included in this PR?
Code, tests, upgrading doc.
Are these changes tested?
Yes, with existing tests.
Are there any user-facing changes?
Yes. Any query that used to use the default timezone would return a timestamp with a timezone of 'Z' will now return a timestamp without a timezone. This can be changed back to the previous behaviour with the sql