Skip to content

Conversation

@proost
Copy link
Contributor

@proost proost commented Nov 15, 2025

Adding Union operation of theta sketches.

)

// Union computes the union of Theta sketches.
type Union struct {
Copy link
Member

@freakyzoidberg freakyzoidberg Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind naming this ThetaUnion (Union is too generic and this get confusing on the call site when mixing different sketch type)

(I probably missed other case like that, I ll do a pass to qualify those exported types)

Thanks

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some context here, the name colision thing is a larger problem - for the Go repo it's going to be easier to address now than later

https://lists.apache.org/thread/4c78gsls7xjrn0b4cosvppywh2clwz6x

Copy link
Contributor Author

@proost proost Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some context here, the name colision thing is a larger problem - for the Go repo it's going to be easier to address now than later

Yes, I agree that. But In go, always use package as accessor. And even if packages are conflicted, user can change package name using alias when import.

refs:
https://go.dev/wiki/CodeReviewComments#package-names
https://go.dev/blog/package-names#naming-package-contents
https://go.dev/doc/effective_go#package-names

Copy link
Contributor Author

@proost proost Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But adding prefix is project or community rule, I will follow it. Do you want still change it?

Copy link
Member

@freakyzoidberg freakyzoidberg Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets go with Go convention here - thanks

@freakyzoidberg freakyzoidberg merged commit 2cdea18 into apache:main Nov 18, 2025
1 check passed
@proost proost deleted the feat-theta-union branch November 18, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants