Skip to content

perf: use direct comparison #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
freakyzoidberg merged 2 commits into from
Dec 10, 2025
+8 −9
Merged

perf: use direct comparison #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0111d0
perf: use direct comparison
proost Dec 10, 2025
5c5acc7
perf: use direct comparision for a not b
proost Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions theta/a_not_b.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
package theta

import (
"errors"
"fmt"
"slices"

Expand Down Expand Up @@ -118,7 +117,7 @@ func computeHashBased(a, b Sketch, theta uint64) ([]uint64, error) {
for entry := range b.All() {
if entry < theta {
idx, err := table.Find(entry)
if err != nil && errors.Is(err, ErrKeyNotFoundAndNoEmptySlots) {
if err != nil && err == ErrKeyNotFoundAndNoEmptySlots {
return nil, err
}

Expand All @@ -133,7 +132,7 @@ func computeHashBased(a, b Sketch, theta uint64) ([]uint64, error) {
for entry := range a.All() {
if entry < theta {
_, err := table.Find(entry)
if err != nil && errors.Is(err, ErrKeyNotFound) {
if err != nil && err == ErrKeyNotFound {
entries = append(entries, entry)
}
} else if a.IsOrdered() {
Expand Down
2 changes: 1 addition & 1 deletion theta/intersection.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ func (i *Intersection) Update(sketch Sketch) error {
i.hashtable = NewHashtable(lgSize, lgSize-1, ResizeX1, 1.0, i.hashtable.theta, i.hashtable.seed, i.hashtable.isEmpty)
for j := 0; j < matchCount; j++ {
key, err := i.hashtable.Find(matchesEntries[j])
if err != nil && errors.Is(err, ErrKeyNotFoundAndNoEmptySlots) {
if err != nil && err == ErrKeyNotFoundAndNoEmptySlots {
return err
}

Expand Down
2 changes: 1 addition & 1 deletion theta/union.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ func (u *Union) Update(sketch Sketch) error {
if entry < u.theta && entry < u.hashtable.theta {
index, err := u.hashtable.Find(entry)
if err != nil {
if errors.Is(err, ErrKeyNotFound) {
if err == ErrKeyNotFound {
u.hashtable.Insert(index, entry)
continue
}
Expand Down
8 changes: 4 additions & 4 deletions theta/update_sketch.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ func (s *QuickSelectUpdateSketch) UpdateInt64(value int64) error {

index, err := s.table.Find(hash)
if err != nil {
if errors.Is(err, ErrKeyNotFound) {
if err == ErrKeyNotFound {
s.table.Insert(index, hash)
return nil
}
Expand All @@ -292,7 +292,7 @@ func (s *QuickSelectUpdateSketch) UpdateInt32(value int32) error {

index, err := s.table.Find(hash)
if err != nil {
if errors.Is(err, ErrKeyNotFound) {
if err == ErrKeyNotFound {
s.table.Insert(index, hash)
return nil
}
Expand Down Expand Up @@ -362,7 +362,7 @@ func (s *QuickSelectUpdateSketch) UpdateString(value string) error {

index, err := s.table.Find(hash)
if err != nil {
if errors.Is(err, ErrKeyNotFound) {
if err == ErrKeyNotFound {
s.table.Insert(index, hash)
return nil
}
Expand All @@ -382,7 +382,7 @@ func (s *QuickSelectUpdateSketch) UpdateBytes(data []byte) error {

index, err := s.table.Find(hash)
if err != nil {
if errors.Is(err, ErrKeyNotFound) {
if err == ErrKeyNotFound {
s.table.Insert(index, hash)
return nil
}
Expand Down