feat: set operations for tuple sketch #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
No worries, I'll try doing the review today. Enjoy your vacation anyway ! Thanks |
freakyzoidberg
requested changes
Dec 14, 2025
|
|
||
| if ordered && !a.IsOrdered() { | ||
| slices.SortFunc(entries, func(a, b entry[S]) int { | ||
| return int(a.Hash - b.Hash) |
Member
There was a problem hiding this comment.
This could overflow/underflow, safer to just compare them
..., func(a, b entry[S]) int {
if a.Hash < b.Hash {
return -1
} else if a.Hash > b.Hash {
return 1
}
return 0
}
|
|
||
| if ordered && !a.IsOrdered() { | ||
| slices.SortFunc(entries, func(a, b entry[S]) int { | ||
| return int(a.Hash - b.Hash) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for big change.
Because of vacation about two weeks, so I send big PR.
feedbacks will be applied after vacation.
After merged, I will upload benchmark to datasketches-characterization like theta sketch.