-
Notifications
You must be signed in to change notification settings - Fork 8
feat: implement count-min sketch #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR implements a Count-Min sketch data structure for approximate frequency counting in streaming data. The implementation provides configurable accuracy through relative error and confidence parameters, supports negative weights, and includes serialization/deserialization compatibility with the DataSketches format.
Key changes:
- Core Count-Min sketch with update, estimate, merge, and bound calculation operations
- Helper functions for parameter suggestions based on desired error and confidence levels
- Serialization support compatible with DataSketches Count-Min format
- Comprehensive test suite covering basic operations, edge cases, and serialization
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/lib.rs | Adds countmin module to the library's public API |
| src/countmin/mod.rs | Module definition with documentation and public exports |
| src/countmin/sketch.rs | Core Count-Min sketch implementation with update, estimation, merge, and serialization methods |
| src/countmin/serialization.rs | Serialization constants and helper functions for DataSketches format compatibility |
| tests/countmin_test.rs | Comprehensive test suite covering initialization, updates, bounds, merge, serialization, and edge cases |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Cool! Thanks. I'll take a look soon... |
Signed-off-by: Chojan Shang <[email protected]>
Related to #35