feat: add frequencies sketches #44
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chojan Shang <[email protected]>
Signed-off-by: Chojan Shang <[email protected]>
Signed-off-by: Chojan Shang <[email protected]>
Member
Author
|
only 1 serde case failed on windows, ... on windows, long is 32‑bit...... |
|
Probably don’t need to bother with a dedicated implementation for longs. That was mostly for initial testing, I think. And if rust supports templates/generics with primitives then there’s no reason for a separate implementation for longs. We didn’t do one for c++, just provided a default serde for a few basic types. |
Member
Author
|
you're right.
I'll mark this pr as a draft for now. Later, I'll remove longsketch, update the tests, and skip the serde errors on Windows. |
Signed-off-by: Chojan Shang <[email protected]>
Contributor
|
I need to see some Rust reviewers before I approve & merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.