Skip to content

branch-3.1: [Fix](warmup) Fix wrongly skip download task for warmup job when rowsets have multi segments #56663 #56680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: [compile](arm) fix arm compile failed
merged 1 commit into from
Oct 11, 2025
Merged

branch-3.1: [Fix](warmup) Fix wrongly skip download task for warmup job when rowsets have multi segments #56663 #56680

merged 1 commit into from
Oct 11, 2025

Conversation

@github-actions
Copy link
Contributor

Cherry-picked from #56663

@bobhan1
[Fix](warmup) Fix wrongly skip download task for warmup job when rows…
7a9f7e4 
…ets have multi segments (#56663)

### What problem does this PR solve?

introduced in #54611

Related PR: #xxx

Problem Summary:

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@github-actions github-actions bot requested a review from morrySnow as a code owner September 30, 2025 11:25
@Thearas
Copy link
Contributor

Thearas commented Sep 30, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Sep 30, 2025
@Thearas
Copy link
Contributor

Thearas commented Sep 30, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32504 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7a9f7e48eeea9277bfb31157d398dbe0d543b2d9, data reload: false

------ Round 1 ----------------------------------
q1	17587	5450	5509	5450
q2	2023	386	276	276
q3	12366	1231	758	758
q4	10351	862	464	464
q5	9598	2375	2099	2099
q6	188	168	134	134
q7	892	745	598	598
q8	9333	1427	1184	1184
q9	5375	4983	4910	4910
q10	6758	2262	1831	1831
q11	477	280	258	258
q12	337	360	207	207
q13	17783	3605	3003	3003
q14	230	228	221	221
q15	523	470	464	464
q16	426	426	365	365
q17	580	851	359	359
q18	6849	6262	6460	6262
q19	1223	941	542	542
q20	326	342	199	199
q21	2764	2164	1926	1926
q22	1077	1055	994	994
Total cold run time: 107066 ms
Total hot run time: 32504 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5570	5479	5462	5462
q2	240	325	233	233
q3	2258	2604	2296	2296
q4	1335	1833	1343	1343
q5	4381	4973	4965	4965
q6	187	166	131	131
q7	2089	1998	1829	1829
q8	2629	2807	2680	2680
q9	7302	7286	7203	7203
q10	3039	3224	2782	2782
q11	582	511	492	492
q12	657	749	581	581
q13	3419	3755	3137	3137
q14	272	287	295	287
q15	527	475	479	475
q16	448	474	440	440
q17	1219	1736	1246	1246
q18	7553	7410	7450	7410
q19	792	1176	1072	1072
q20	2006	2062	1907	1907
q21	5316	4986	4444	4444
q22	1133	1088	1063	1063
Total cold run time: 52954 ms
Total hot run time: 51478 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 193232 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7a9f7e48eeea9277bfb31157d398dbe0d543b2d9, data reload: false

query1	947	408	396	396
query2	6215	1950	1888	1888
query3	8688	193	193	193
query4	33622	24216	23475	23475
query5	4333	605	458	458
query6	301	191	178	178
query7	4215	497	324	324
query8	300	249	236	236
query9	9445	2629	2632	2629
query10	485	322	268	268
query11	17940	15393	15223	15223
query12	152	112	109	109
query13	1585	556	428	428
query14	9148	6650	7480	6650
query15	244	188	177	177
query16	8121	656	511	511
query17	1585	793	607	607
query18	2160	441	325	325
query19	233	210	175	175
query20	132	124	123	123
query21	205	130	113	113
query22	4618	4573	4727	4573
query23	35089	34178	34280	34178
query24	7346	2679	2714	2679
query25	553	515	434	434
query26	815	285	175	175
query27	2029	493	373	373
query28	5470	2286	2265	2265
query29	708	614	464	464
query30	244	196	171	171
query31	967	948	839	839
query32	94	64	58	58
query33	485	382	319	319
query34	741	849	517	517
query35	809	848	758	758
query36	989	1036	982	982
query37	111	93	67	67
query38	4023	4041	4033	4033
query39	1506	1514	1474	1474
query40	209	116	101	101
query41	48	47	47	47
query42	127	114	106	106
query43	494	510	467	467
query44	1425	837	828	828
query45	192	190	175	175
query46	907	1065	675	675
query47	2011	1979	1967	1967
query48	413	440	352	352
query49	722	487	417	417
query50	693	721	452	452
query51	7371	7381	7275	7275
query52	103	101	92	92
query53	231	266	192	192
query54	563	570	489	489
query55	80	79	83	79
query56	280	296	268	268
query57	1317	1294	1217	1217
query58	244	241	241	241
query59	3161	3264	3035	3035
query60	300	273	285	273
query61	114	121	120	120
query62	809	764	711	711
query63	228	195	198	195
query64	3745	1005	665	665
query65	3398	3313	3298	3298
query66	796	401	310	310
query67	16034	15790	15717	15717
query68	7851	870	552	552
query69	501	309	270	270
query70	1186	1150	1083	1083
query71	381	297	266	266
query72	5705	3753	3962	3753
query73	637	745	369	369
query74	10273	9292	9273	9273
query75	3224	3181	2720	2720
query76	3050	1164	780	780
query77	522	365	276	276
query78	10286	10435	9720	9720
query79	3788	857	589	589
query80	732	516	436	436
query81	520	257	220	220
query82	570	118	94	94
query83	173	165	152	152
query84	287	106	83	83
query85	780	349	308	308
query86	405	319	299	299
query87	4326	4397	4202	4202
query88	5010	2519	2498	2498
query89	406	331	288	288
query90	1744	210	192	192
query91	138	138	110	110
query92	67	62	52	52
query93	2244	898	552	552
query94	685	409	306	306
query95	358	281	274	274
query96	487	606	285	285
query97	3267	3259	3135	3135
query98	224	214	196	196
query99	1517	1424	1290	1290
Total cold run time: 294012 ms
Total hot run time: 193232 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 28.54 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7a9f7e48eeea9277bfb31157d398dbe0d543b2d9, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.04	0.03
query3	0.23	0.07	0.07
query4	1.62	0.10	0.11
query5	0.51	0.51	0.51
query6	1.13	0.73	0.72
query7	0.02	0.02	0.02
query8	0.05	0.03	0.03
query9	0.58	0.49	0.50
query10	0.55	0.55	0.55
query11	0.14	0.11	0.10
query12	0.14	0.11	0.11
query13	0.62	0.60	0.60
query14	0.77	0.80	0.80
query15	0.83	0.83	0.82
query16	0.37	0.38	0.38
query17	1.06	1.01	1.07
query18	0.24	0.22	0.22
query19	1.94	1.88	1.86
query20	0.02	0.01	0.02
query21	15.41	0.92	0.59
query22	0.73	0.79	0.75
query23	15.05	1.42	0.57
query24	2.92	0.45	1.82
query25	0.14	0.16	0.07
query26	0.36	0.14	0.13
query27	0.05	0.07	0.04
query28	13.50	0.97	0.43
query29	12.59	3.89	3.29
query30	0.26	0.10	0.07
query31	2.81	0.59	0.39
query32	3.23	0.53	0.47
query33	3.02	3.02	2.97
query34	16.80	5.20	4.53
query35	4.59	4.53	4.58
query36	0.66	0.49	0.49
query37	0.08	0.05	0.06
query38	0.04	0.04	0.04
query39	0.04	0.03	0.02
query40	0.16	0.12	0.12
query41	0.08	0.03	0.03
query42	0.04	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 103.53 s
Total hot run time: 28.54 s

@bobhan1
Copy link
Contributor

bobhan1 commented Oct 9, 2025

run p0

@bobhan1
Copy link
Contributor

bobhan1 commented Oct 9, 2025

run cloud_p0

@morrySnow morrySnow merged commit ec9c05d into branch-3.1 Oct 11, 2025
21 of 22 checks passed
@github-actions github-actions bot deleted the auto-pick-56663-branch-3.1 branch October 11, 2025 03:27
@morrySnow morrySnow mentioned this pull request Oct 23, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Thearas @doris-robot @bobhan1 @morrySnow @dataroaring