Skip to content

fix: tooltip formatter callback for connected charts. close #21307 #21314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+178 −2
Open

fix: tooltip formatter callback for connected charts. close #21307 #21314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/component/tooltip/TooltipView.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,8 +295,12 @@ class TooltipView extends ComponentView {

const dispatchAction = makeDispatchAction(payload, api);

// Reset ticket
this._ticket = '';
/** Note: We don't reset the ticket here anymore, because if the tooltip content
* hasn't changed, we want to preserve the async ticket so that pending callbacks
* can still update the tooltip. The ticket will be reset in _showTooltipContent
* when new content is actually shown.
*/
// this._ticket = '';

// When triggered from axisPointer.
const dataByCoordSys = payload.dataByCoordSys;
Expand Down
172 changes: 172 additions & 0 deletions test/tooltip-async-connect.html
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.