-
Notifications
You must be signed in to change notification settings - Fork 19.8k
fix(candlestick): fix candlestick render error with series.encode
#21325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thanks for your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! I left a few comments.
| x: [1, 3, 2, 4], | ||
| y: 0, | ||
| }, | ||
| data: daval, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add more cases to test the behavior when:
- xAxis is time
- xAxis is category
- yAxis is time
- yAxis is category
- encode 0 as y
- encode 0 as x
- data uses
daval - data uses
datay
And it would be better if you also test if this change works for #20319 (include boxplot on time axis) as well.
series.encode
series.encodeseries.encode
series.encodeseries.encode
Brief Information
This pull request is in the type of:
What does this PR do?
Fixes TypeError: Cannot read properties of undefined (reading 'sign') and displays horizontal candlesticks properly
Fixed issues
Details
Before: What was the problem?
After: How does it behave after the fixing?
Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Others
Merging options
Other information