Skip to content

Conversation

@PPRAMANIK62
Copy link

@PPRAMANIK62 PPRAMANIK62 commented Oct 20, 2025

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fixes TypeError: Cannot read properties of undefined (reading 'sign') and displays horizontal candlesticks properly

Fixed issues

Details

Before: What was the problem?

Screenshot_20-Oct_19-45-20_18405

After: How does it behave after the fixing?

Screenshot_20-Oct_19-43-42_30857

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Oct 20, 2025

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

Copy link
Member

@plainheart plainheart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I left a few comments.

x: [1, 3, 2, 4],
y: 0,
},
data: daval,
Copy link
Member

@plainheart plainheart Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add more cases to test the behavior when:

  • xAxis is time
  • xAxis is category
  • yAxis is time
  • yAxis is category
  • encode 0 as y
  • encode 0 as x
  • data uses daval
  • data uses datay

And it would be better if you also test if this change works for #20319 (include boxplot on time axis) as well.

@plainheart plainheart changed the title fix: horizontal candlesticks with encode. close #21322 fix(candlestick): fix horizontal candlesticks error with series.encode Oct 23, 2025
@plainheart plainheart changed the title fix(candlestick): fix horizontal candlesticks error with series.encode fix(candlestick): fix candlesticks error with series.encode Oct 23, 2025
@plainheart plainheart changed the title fix(candlestick): fix candlesticks error with series.encode fix(candlestick): fix candlestick render error with series.encode Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] on horizontal candlestick

2 participants