Skip to content

Conversation

beliefer
Copy link
Contributor

What is the purpose of the change

This PR aims to remove unused getJobGraph from PipelineExecutorUtils.
The method getJobGraph in PipelineExecutorUtils is only used in test cases.
The client uses StreamGraph now. We should update these test cases.

Brief change log

Remove unused getJobGraph from PipelineExecutorUtils.

Verifying this change

This change is already covered by existing tests, such as (DefaultPackagedProgramRetrieverITCase).

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

@flinkbot
Copy link
Collaborator

flinkbot commented Aug 24, 2025

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@beliefer
Copy link
Contributor Author

@davidradl Thank you!

@github-actions github-actions bot added community-reviewed PR has been reviewed by the community. and removed community-reviewed PR has been reviewed by the community. labels Aug 26, 2025
@github-actions github-actions bot added community-reviewed PR has been reviewed by the community. and removed community-reviewed PR has been reviewed by the community. labels Sep 3, 2025
@github-actions github-actions bot added community-reviewed PR has been reviewed by the community. and removed community-reviewed PR has been reviewed by the community. labels Sep 5, 2025
jobGraph.getClasspaths().stream().map(URL::toString).collect(Collectors.toList());
streamGraph.getClasspaths().stream()
.map(URL::toString)
.collect(Collectors.toList());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we extract this

streamGraph.getClasspaths().stream()
                        .map(URL::toString)
                        .collect(Collectors.toList());

into a separate method, it is duplicated in this class multiple times

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@beliefer beliefer requested a review from snuyanzin September 21, 2025 07:44
@snuyanzin snuyanzin merged commit a70ca9c into apache:master Sep 24, 2025
@beliefer
Copy link
Contributor Author

@snuyanzin Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-reviewed PR has been reviewed by the community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants