Skip to content

HBASE-29501 IOException in SerialReplicationChecker.canPush causes entries to be pushed out of order #7194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: branch-2.6
Choose a base branch
from
+5 −0
Open

HBASE-29501 IOException in SerialReplicationChecker.canPush causes entries to be pushed out of order #7194

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab322dd
HBASE-29501 IOException in SerialReplicationChecker.canPush causes en…
tomasbanet Aug 1, 2025
e81eeac
Change break to continue
tomasbanet Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...va/org/apache/hadoop/hbase/replication/regionserver/SerialReplicationSourceWALReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,11 @@ protected void readWALEntries(WALEntryStream entryStream, WALEntryBatch batch)
break;
}
sleepMultiplier = sleep(sleepMultiplier);
// Always make sure to continue/break from the loop after handling the exception.
// Otherwise we will drop down below into logic to push the entry,
// but since we don't know if the entry can be pushed we may push
// the entry out of order, breaking serial replication guarantees.
continue;
}
// arrive here means we can push the entry, record the last sequence id
batch.setLastSeqId(Bytes.toString(entry.getKey().getEncodedRegionName()),
Expand Down