HBASE-29609 Upgrade checkstyle and Maven checkstyle plugin to fix site build failure

[PDavid]

No description provided.

[PDavid]

Executed mvn clean install -DskipTests && mvn site -DskipTests locally and it was successful.

[stoty]

Do these versions work with Java 8 ?

[stoty]

I guess we need this on every branch, otherwise the yestus checkstlye checks would also fail ?

[PDavid]

Do these versions work with Java 8 ?

Thanks, good question. I just checked. Unfortunately these does not work with Java 8. These require at least Java 17.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 33s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
			_ master Compile Tests _
+1 💚	mvninstall	4m 17s		master passed
+1 💚	compile	11m 12s		master passed
+1 💚	spotless	1m 0s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+1 💚	mvninstall	3m 55s		the patch passed
+1 💚	compile	9m 44s		the patch passed
+1 💚	javac	9m 44s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	xmllint	0m 0s		No new issues.
+1 💚	hadoopcheck	13m 1s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚	spotless	0m 46s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 12s		The patch does not generate ASF License warnings.
		52m 40s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7321/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#7321
Optional Tests	dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile
uname	Linux cb7f0635886e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 23ae45d
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	189 (vs. ulimit of 30000)
modules	C: . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7321/1/console
versions	git=2.34.1 maven=3.9.8 xmllint=20913
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[PDavid]

RestoreBackupSystemTableProcedure is just being introduced on branch-2 under this PR: #7317
So it is not there yet in branch-2.

But as I see in #7317 the author used different syntax for the same switch.

      case RESTORE_BACKUP_SYSTEM_TABLE_DISABLE:
      case RESTORE_BACKUP_SYSTEM_TABLE_PREPARE:
        return;

vs.

      case RESTORE_BACKUP_SYSTEM_TABLE_DISABLE, RESTORE_BACKUP_SYSTEM_TABLE_PREPARE:
        return;

The problem is with the latter (on master) because this is Java 14+ syntax.
So this will not be a problem on branch-2.

[stoty]

+1 LGTM for branch-3+

[hgromer]

Thank you for the heads up, I will update my backport

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 20s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+1 💚	mvninstall	4m 25s		master passed
+1 💚	compile	2m 51s		master passed
+1 💚	javadoc	2m 22s		master passed
+1 💚	shadedjars	7m 22s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	3m 53s		the patch passed
+1 💚	compile	2m 41s		the patch passed
+1 💚	javac	2m 41s		the patch passed
+1 💚	javadoc	2m 28s		the patch passed
+1 💚	shadedjars	6m 50s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	283m 45s		root in the patch passed.
		326m 53s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7321/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#7321
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 0eefde9fe90f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 23ae45d
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7321/1/testReport/
Max. process+thread count	7154 (vs. ulimit of 30000)
modules	C: . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7321/1/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.