HIVE-29267: Fix NPE on Grouping Sets Optimizer for UNION ALL Queries #6128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@okumin can you help to review this PR. Thanks |
okumin
reviewed
Oct 15, 2025
| select grpBy_col, sum(col2) | ||
| from | ||
| ( select 'abc' as grpBy_col, col2 from sub_qr union all select 'def' as grpBy_col, col2 from sub_qr) x | ||
| group by grpBy_col with rollup; |
There was a problem hiding this comment.
I confirmed the master branch definitely throws a NPE
ql/src/java/org/apache/hadoop/hive/ql/optimizer/GroupingSetOptimizer.java
Outdated
Show resolved
Hide resolved
Indhumathi27
force-pushed
the
union_grp_set
branch
from
5050529 to
f8bcb20
Compare
asf-ci-hive
added
tests pending
tests passed
and removed
tests passed
tests pending
labels
ngsg
approved these changes
Oct 15, 2025
ql/src/java/org/apache/hadoop/hive/ql/optimizer/GroupingSetOptimizer.java
Outdated
Show resolved
Hide resolved
Indhumathi27
force-pushed
the
union_grp_set
branch
from
f8bcb20 to
7bf00f1
Compare
asf-ci-hive
added
tests pending
tests unstable
and removed
tests passed
tests pending
labels
Indhumathi27
force-pushed
the
union_grp_set
branch
from
7bf00f1 to
60596a6
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This change adds a defensive null check before accessing
getColumnExprMap()Why are the changes needed?
This PR fixes a
NullPointerException(orcolExprMap is nullissue) that occurs when the parent operator is aUnionOperatorduring column statistics or partition column inference.The root cause is that
UnionOperatordoes not initializecolExprMap, since it merely merges rows from multiple inputs and does not perform column expression transformations.Existing code paths assumed that every parent operator had a non-null
colExprMap, which led to NPEs when traversing the operator tree.Does this PR introduce any user-facing change?
No
How was this patch tested?
Test scenario added