HIVE-29270: Remove HMS compactor workers deprecated functionality #6132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asf-ci-hive
added
tests pending
tests unstable
tests passed
and removed
tests pending
tests unstable
labels
dengzhhu653
approved these changes
Oct 17, 2025
|
@tanishq-chugh besides HMS local workers support, please drop the supplemental functionality such as revokeFromLocalWorkers: #6068 |
asf-ci-hive
added
tests pending
tests passed
and removed
tests passed
tests pending
labels
|
Addressed dropping revokeFromLocalWorkers supplementary functionality in commit - 5350c3d |
deniskuzZ
reviewed
Oct 17, 2025
ql/src/test/org/apache/hadoop/hive/ql/txn/compactor/TestInitiator.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Oct 17, 2025
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Oct 17, 2025
| startedAt = System.currentTimeMillis(); | ||
| prevStart = handle.getLastUpdateTime(); | ||
|
|
||
| recoverFailedCompactions(); |
There was a problem hiding this comment.
could you please add new line after and keep the comment: // Check for timed out workers.
There was a problem hiding this comment.
Yes, added in commit ed91be6
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Removal of the deprecated functionality of HMS compactor workers
Why are the changes needed?
The particular functionality has been deprecated since a long time pending for removal.
Does this PR introduce any user-facing change?
More of a configuration removal, that user won't be able to update/use in upcoming releases.
How was this patch tested?
Manual verification & CI