Fixes for several string formats, they are based on static analysis. #6306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlsi
requested changes
Aug 6, 2024
src/protocol/java/src/main/java/org/apache/jmeter/protocol/java/sampler/JavaSampler.java
Outdated
Show resolved
Hide resolved
| log.info("Created class: %s. Uses tearDownTest: %b", name, isToBeRegistered); | ||
| } catch (Exception e) { | ||
| log.error("{}\tException initialising: ", whoAmI(), name, e); | ||
| log.error("%s\tException initialising: %s %s", whoAmI(), name, e.getMessage()); |
There was a problem hiding this comment.
Suggested change
| log.error("%s\tException initialising: %s %s", whoAmI(), name, e.getMessage()); | |
| log.error("{}\tException initialising: {} {}", whoAmI(), name, e.getMessage()); |
vlsi
reviewed
Aug 7, 2024
src/protocol/java/src/main/java/org/apache/jmeter/protocol/java/sampler/JavaSampler.java
Outdated
Show resolved
Hide resolved
FSchumacher
reviewed
Sep 27, 2024
...protocol/http/src/main/java/org/apache/jmeter/protocol/http/proxy/DefaultSamplerCreator.java
Show resolved
Hide resolved
src/protocol/tcp/src/main/java/org/apache/jmeter/protocol/tcp/sampler/TCPSampler.java
Show resolved
Hide resolved
…a/sampler/JavaSampler.java Co-authored-by: Vladimir Sitnikov <[email protected]>
FSchumacher
reviewed
Oct 25, 2024
| log.info("Created class: {}. Uses tearDownTest: {}", name, isToBeRegistered); | ||
| } catch (Exception e) { | ||
| log.error("{}\tException initialising: ", whoAmI(), name, e); | ||
| log.error("{}\tException initialising: {}", whoAmI(), name, e); |
There was a problem hiding this comment.
While the text in the message looks like it is missing a placeholder, I would refrain from adding it here. Adding a placeholder will loose the stacktrace, which could be helpful identifying the root cause.
There was a problem hiding this comment.
I restored this placeholder
vlsi
reviewed
Nov 28, 2024
src/protocol/java/src/main/java/org/apache/jmeter/protocol/java/sampler/JavaSampler.java
Outdated
Show resolved
Hide resolved
…a/sampler/JavaSampler.java Co-authored-by: Vladimir Sitnikov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for several string formats, they are based on static analysis.