MINOR: Update the definition of Average Poll Idle Ratio in KRaft monitoring metrics. #707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @MahsaSeifikar, thanks for spotting this. I think these changes need to be first applied to trunk, 4.1, 4.0 and 3.9 branches. Note that, on this branch, there is already a PR opened for 4.1 release, that is currently being voted and that we would also need to update. |
Thanks for letting me know. I'll update the trunk then. Should I close this pull request as well? |
|
Maybe you can simply convert to draft until the other bits are ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The definition of the average poll idle ratio was changed in KAFKA-14664, but the doc has not yet been updated to reflect the new definition.