Skip to content

Conversation

clolov
Copy link
Contributor

@clolov clolov commented Sep 3, 2025

No description provided.

@clolov
Copy link
Contributor Author

clolov commented Sep 3, 2025

I had a quick check, because I was surprised to see the protocol_messages.html being included. As far as I can see the additions (I spot-checked some of them), have been present since December 2024 and are in the source code. As such, I think the current PR is correct, but I am happy to hear other opinions on the subject because I might be overlooking something simple

@clolov clolov force-pushed the asf-site-4-0-1-doc-update branch from 382011f to 82584e1 Compare September 11, 2025 10:00
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't expected changes here but that looks correct. Not sure what happened with protocol_messages.html for 4.0 but it looks like it's currently wrong.

@clolov clolov requested a review from mimaison September 30, 2025 12:52
Copy link
Member

@mimaison mimaison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants