KAFKA-19527: improve the docs of LogDirDescription for remote storage #20211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The implementation calculates these values based on the local log directories and does not account for remote storage. kafka/core/src/main/scala/kafka/server/ReplicaManager.scala Lines 1238 to 1239 in 12761c0 |
|
A label of 'needs-attention' was automatically added to this PR in order to raise the |
chia7712
approved these changes
Jul 30, 2025
k-apol
pushed a commit
to k-apol/kafka
that referenced
this pull request
Aug 8, 2025
…pache#20211) Clarifies that the fields `LogDirDescription#totalBytes`, `LogDirDescription#usableBytes`, and `ReplicaInfo#size` do not include the size of remote storage by updating their corresponding docs. Reviewers: Chia-Ping Tsai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarifies that the fields
LogDirDescription#totalBytes,LogDirDescription#usableBytes, andReplicaInfo#sizedo not includethe size of remote storage by updating their corresponding docs.
Reviewers: Chia-Ping Tsai [email protected]