-
Notifications
You must be signed in to change notification settings - Fork 14.6k
MINOR: Add project icon for IntelliJ IDEA
#20215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
kindly request your eyes on this assuming its a low hanging fruit, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the patch! Could you update the PR title to use MINOR: as the prefix?
IntelliJ IDEA
IntelliJ IDEA
This comment was marked as resolved.
This comment was marked as resolved.
@Pankraz76 thanks for your contribution. I don't quite understand the purpose of having the icon in Intellij. Could you share your thoughts with me? |
Thanks for the response. It’s just a nice little gimmick to improve the look and feel. It helps (me) quickly recognize projects when switching between them. I can’t say for sure if it’s good for this project. The only feedback I’ve received so far has been positive, and these changes have always been accepted. The only downside is having IDE-specific configs in the repo, which is generally avoided. In this case, all the projects make an exception to support this. |
I just noticed this by accident as well so I like to spread the learning:
|
IntelliJ IDEA
elastic/elasticsearch#131427