MINOR: Cleanups in Tools Module (3/n) #20332
Open
+169
−542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding @chia7712 as he kindly helped with all PR reviews in this region. |
sjhajharia
changed the title
|
A label of 'needs-attention' was automatically added to this PR in order to raise the |
chia7712
reviewed
Aug 18, 2025
| AdminClientService(AclCommandOptions opts) { | ||
| this.opts = opts; | ||
| } | ||
| private record AdminClientService(AclCommandOptions opts) { |
There was a problem hiding this comment.
Rewriting it as static helper methods seems to better than using a record class. WDYT?
| this.err = err; | ||
| } | ||
| private record Config(Command command, Set<Path> locations, boolean dryRun, boolean keepNotFound, PrintStream out, | ||
| PrintStream err) { | ||
|
|
||
| @Override | ||
| public String toString() { |
There was a problem hiding this comment.
how about trusting the generated toString?
| this.topicPartition = topicPartition; | ||
| this.producerState = producerState; | ||
| } | ||
| private record OpenTransaction(TopicPartition topicPartition, ProducerState producerState) { |
There was a problem hiding this comment.
Based on the use cases, using Map<TopicPartition, ProducerState> seems more suitable.
tools/src/main/java/org/apache/kafka/tools/reassign/ActiveMoveState.java
Show resolved
Hide resolved
| public CancelledMoveState(String currentLogDir, String targetLogDir) { | ||
| this.currentLogDir = currentLogDir; | ||
| this.targetLogDir = targetLogDir; | ||
| CancelledMoveState { |
| */ | ||
| public CompletedMoveState(String targetLogDir) { | ||
| this.targetLogDir = targetLogDir; | ||
| CompletedMoveState { |
| */ | ||
| public MissingLogDirMoveState(String targetLogDir) { | ||
| this.targetLogDir = targetLogDir; | ||
| MissingLogDirMoveState { |
| */ | ||
| public MissingReplicaMoveState(String targetLogDir) { | ||
| this.targetLogDir = targetLogDir; | ||
| MissingReplicaMoveState { |
| this.path = path; | ||
| } | ||
|
|
||
| private record PluginLocation(Path path) { | ||
| @Override | ||
| public String toString() { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at cleaning up the tools module further by getting rid of some extra code which can be replaced by
record