KAFKA-18699: Cleanup Metadata Module #20346
Open
+116
−1,153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mingyen066
reviewed
Aug 14, 2025
There was a problem hiding this comment.
The cleanup for migrating suitable classes to records has a corresponding JIRA ticket: KAFKA-18696.
For metadata cleanup, you can take my ticket: KAFKA-18699.
| return other.current == current && other.next == next; | ||
| } | ||
|
|
||
| record BrokerControlStates(BrokerControlState current, BrokerControlState next) { | ||
| @Override |
There was a problem hiding this comment.
Why not remove toString as well? As far as I know, the only difference is that the parentheses become square brackets.
sjhajharia
changed the title
|
Thanks @mingyen066 |
m1a2st
reviewed
Aug 14, 2025
metadata/src/main/java/org/apache/kafka/image/MetadataProvenance.java
Outdated
Show resolved
Hide resolved
metadata/src/main/java/org/apache/kafka/metadata/placement/TopicAssignment.java
Show resolved
Hide resolved
|
Thanks @m1a2st for the review. I have addressed the comments. Pls re-review. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/KAFKA-18699
This PR aims at cleaning up the
metadatamodule further by getting ridof some extra code which can be replaced by record