[MNG-8696] Hide the cache from DefaultDependencyResolverResult constructor #11154
Conversation
…uctor (apache#2347) Make package-private the `DefaultDependencyResolverResult` constructor having a `PathModularizationCache` argument, and add a public constructor without the cache argument for code in other packages that need to instantiate. The public constructor may be temporary, until we decide in the future where to store session-wide cache.
| import static org.apache.maven.impl.ImplUtils.map; | ||
|
|
||
| @Named | ||
| @Singleton |
There was a problem hiding this comment.
If the bean contains session-specific data, maybe we want to make it @SessionScope rather than @Singleton. That may be one possible answer to "until clarified where to store session-wide caches".
There was a problem hiding this comment.
Maybe I have misused the "session" word, since I'm not sure which data are in a session. This cache should be valid as long as the JAR files do not change. For JAR files that are not produced by the project, it should be the JVM lifetime. For JAR files produced by the project and used as dependencies by sub-projects, this is an open question...
|
Merged in its current form for consistency with the master branch. If |
2 participants
This is a port of #2347. The intend is to avoid merge conflict with future ports such as #11153.